add safety wrapper around sys.stdout assignment #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks okay, but make sure to add news fragment, and add issue it solves in commit message. |
asottile
reviewed
Jan 4, 2018
tox/venv.py
Outdated
| redirect=self.session.report.verbosity < 2) | ||
| sys.stdout = old_stdout | ||
| try: | ||
| sys.stdout = codecs.getwriter('utf8')(sys.stdout) |
There was a problem hiding this comment.
this should be outside of the try I think?
tox/venv.py
Outdated
| self._pcall(argv, cwd=self.envconfig.config.toxinidir, action=action, | ||
| redirect=self.session.report.verbosity < 2) | ||
| except Exception: | ||
| raise |
There was a problem hiding this comment.
can remove these two lines, they do nothing try: finally: is valid.
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 11 11
Lines 2427 2427
=======================================
Hits 2304 2304
Misses 123 123Continue to review full report at Codecov.
|
asottile
approved these changes
Jan 4, 2018
|
@gaborbernat added changelog entry in b33d6d5 Anything else required for this PR? |
gaborbernat
approved these changes
Jan 5, 2018
This was referenced Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #723 for details on why this PR is being raised
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,miscCONTRIBUTORS(preserving alphabetical order)