Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dyn keyword #395

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Add explicit dyn keyword #395

merged 1 commit into from
Aug 5, 2019

Conversation

kpp
Copy link
Member

@kpp kpp commented Aug 4, 2019

No description provided.

@@ -36,7 +36,7 @@ impl GetPayloadError {
}

impl Fail for GetPayloadError {
fn cause(&self) -> Option<&Fail> {
fn cause(&self) -> Option<&dyn Fail> {
Copy link
Member Author

@kpp kpp Aug 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurnevsky did you miss that one error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it seems...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2524

  • 6 of 7 (85.71%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 96.371%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/toxcore/dht/server/mod.rs 1 2 50.0%
Totals Coverage Status
Change from base Build 2485: 0.005%
Covered Lines: 18880
Relevant Lines: 19591

💛 - Coveralls

@kpp kpp merged commit 28cb87c into master Aug 5, 2019
@kpp kpp deleted the fix_dyn_trait branch August 5, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants