Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace byteorder with std functions #405

Merged
merged 1 commit into from
Oct 1, 2019
Merged

refactor: Replace byteorder with std functions #405

merged 1 commit into from
Oct 1, 2019

Conversation

cronokirby
Copy link
Contributor

Fixes #388.

This favors the x::from_yy_bytes functions instead of using the byteorder crate. This crate is removed as a dependency.

There was a single use of NativeEndian from byteorder, when generating random numbers. This was replaced with a use of from_be_bytes instead. This has no semantic differences, but might be a bit slower on little endian platforms.

The changes were otherwise straightforward.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2571

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 96.275%

Files with Coverage Reduction New Missed Lines %
src/toxcore/dht/server/mod.rs 1 95.12%
src/toxcore/tcp/server/server_ext.rs 1 84.96%
src/toxencryptsave/mod.rs 2 91.84%
Totals Coverage Status
Change from base Build 2552: -0.02%
Covered Lines: 18894
Relevant Lines: 19625

💛 - Coveralls

@kpp kpp merged commit a7a72e5 into tox-rs:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of byteorder
3 participants