Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary clones and async move blocks #435

Merged
merged 1 commit into from
Sep 20, 2020
Merged

refactor: remove unnecessary clones and async move blocks #435

merged 1 commit into from
Sep 20, 2020

Conversation

kurnevsky
Copy link
Member

It became possible after migration to async/await.

@coveralls
Copy link

coveralls commented Sep 19, 2020 •
edited

Pull Request Test Coverage Report for Build 262838889

  • 19 of 22 (86.36%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.804%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tox_core/src/dht/lan_discovery.rs 0 1 0.0%
tox_core/src/onion/client/mod.rs 0 1 0.0%
tox_core/src/relay/client/connections.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 259029674: 0.0%
Covered Lines: 15400
Relevant Lines: 16244
💛 - Coveralls

@kurnevsky
refactor: remove unnecessary clones and async move blocks
e9b62ff 
It became possible after migration to async/await.
@kurnevsky kurnevsky merged commit 62a7ab6 into master Sep 20, 2020
@kpp kpp deleted the no_clone branch September 20, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpp kpp kpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kurnevsky @coveralls @kpp