Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

game_over() -> lives == 0? #91

Closed
jjfiv opened this issue Apr 3, 2019 · 2 comments
Closed

game_over() -> lives == 0? #91

jjfiv opened this issue Apr 3, 2019 · 2 comments
Labels
good first issue Good for newcomers python This should probably be solved in Python.
Milestone
Public Release

Comments

@jjfiv
Copy link
Collaborator

jjfiv commented Apr 3, 2019

I seem to recall we're matching the atari_py on this one but it seems really counter-intuitive to my videogame-sense.
@jjfiv
Copy link
Collaborator Author

jjfiv commented Apr 3, 2019

https://github.com/jjfiv/toybox/blob/d54afebde99e6d90afb68f8cca6d758846cebed3/ctoybox/toybox/toybox/toybox.py#L236-L237

Via #dev discussion: this is a baselines-ism and we want to kill it if possible -> should be done in our Envs but not in our Toybox objects.

@jjfiv jjfiv added good first issue Good for newcomers python This should probably be solved in Python. labels Apr 3, 2019
@jjfiv jjfiv added this to the Public Release milestone Apr 12, 2019
jjfiv added a commit that referenced this issue May 3, 2019
@jjfiv
fix game over semantics but not for OpenAI gym #91
26f2847 
Signed-off-by: John Foley <jjfoley@smith.edu>
jjfiv added a commit that referenced this issue May 3, 2019
@jjfiv
Merge pull request #116 from jjfiv/gameover
954280f 
fix game over semantics but not for OpenAI gym #91
@etosch
Copy link
Collaborator

etosch commented Jan 3, 2020

I think this is currently true, no?

@jjfiv jjfiv closed this as completed Jan 5, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers python This should probably be solved in Python.
Projects
None yet
Milestone
Public Release
Development

No branches or pull requests
2 participants
@etosch @jjfiv