Feature/files #15
Merged
Feature/files #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 25, 2020 14:04
efabens
approved these changes
Mar 30, 2020
| @@ -251,6 +251,300 @@ async function main() { | |||
| main() | |||
| ``` | |||
|
|
|||
| #### Files | |||
There was a problem hiding this comment.
These are really great write ups and examples!
willmichael
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds large file support to the JS SDK!
This works for both Node and the Browser. Care was taken to use streams whenever possible to prevent memory overflow. Each platform provides it's own streams, often wrapped in decorator objects to make the interfaces compatible and behavior more consistent.
Helpers are provided for basic operations on each platform since the return from the read operation is a lower level platform-specific primitive. This is due to the fact that in the browser... well there is no way to save the file to a file system. So to provide flexible enough behavior for different use-cases, the return a a low level primitive, and the helpers convert that into various higher level items, such as strings, object, blobs. etc.
Inline docs are mostly complete. The Readme is also update for this feature.
Questions/ideas welcome.