-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain violation in transform #55
Comments
I wonder if a less strict domain checking (allow |
Possibly. After filing the issue, I thought a bit more about the problem and I'm not sure what the right solution is. My problem clear wants to set |
Can you please provide more context? Eg in a Bayesian model if there is mass around |
It's traditional maximum likelihood optimization and most likely the model that triggered this is wrong. However, people will try to fit wrong models it's a matter of failing in a reasonable way. |
I am very happy to fix this issue, I just need help with what you or other users would consider reasonable. Personally, since an invariant is violated, I prefer failure so that I can learn about it early and investigate. Eg for ML, I would do penalized ML/MAP. Is it a hierarchical model? |
I understand
Yes but the invariant is violated already in julia> transform(t, [-746])
(σ = 0.0,) so that might be where the exception should be thrown from.
Yes indeed it's a hierarchical model. What we are planning to try out is to use constraints instead of transformations for ML. The optimization folks tell us that it is much better. We'll continue to use transformations for Bayesian but the issue here will probably not show up there. |
E.g.
This is causing problems in some optimization code where we optimize over the
Vector
representation and have to convert back and forth. That causes errors similar toThe text was updated successfully, but these errors were encountered: