[lgtm] Fix potentially uninitialized local variable

tpaviot · May 25, 2017 · 112318f · 112318f
1 parent bf9024a
commit 112318f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/examples/core_topology_face.py b/examples/core_topology_face.py
@@ -71,8 +71,8 @@ def face():
 
     ##TopoDS_Wire YellowWire
     MW1 = BRepBuilderAPI_MakeWire(Edge1.Edge(), Edge2.Edge(), Edge3.Edge())
-    if MW1.IsDone():
-        yellow_wire = MW1.Wire()
+    assert MW1.IsDone()
+    yellow_wire = MW1.Wire()
     brown_face = BRepBuilderAPI_MakeFace(yellow_wire)
 
     #The pink face

diff --git a/examples/core_topology_fillet.py b/examples/core_topology_fillet.py
@@ -72,8 +72,8 @@ def variable_filleting(event=None):
 
     Rake.Add(8, 50, next(ex))
     Rake.Build()
-    if Rake.IsDone():
-        evolvedBox = Rake.Shape()
+    assert Rake.IsDone()
+    evolvedBox = Rake.Shape()
     # Create Cylinder
     Cylinder = BRepPrimAPI_MakeCylinder(gp_Ax2(gp_Pnt(-300, 0, 0), gp_Dir(0, 0, 1)), 100, 200).Shape()
     fillet = BRepFilletAPI_MakeFillet(Cylinder)
@@ -86,9 +86,9 @@ def variable_filleting(event=None):
     exp2 = Topo(Cylinder).edges()
     fillet.Add(TabPoint2, next(exp2))
     fillet.Build()
-    if fillet.IsDone():
-        LawEvolvedCylinder = fillet.Shape()
-        display.DisplayShape(LawEvolvedCylinder)
+    assert fillet.IsDone()
+    LawEvolvedCylinder = fillet.Shape()
+    display.DisplayShape(LawEvolvedCylinder)
 
     P = gp_Pnt(350, 0, 0)
     Box2 = BRepPrimAPI_MakeBox(P, 200, 200, 200).Shape()
@@ -115,8 +115,8 @@ def variable_filleting(event=None):
 
     afillet.Add(TabPoint, next(exp))
     afillet.Build()
-    if afillet.IsDone():
-        LawEvolvedBox = afillet.Shape()
+    assert afillet.IsDone()
+    LawEvolvedBox = afillet.Shape()
 
     display.EraseAll()
     display.DisplayShape(Box)