Disable wrapping of non-exported methods #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, all methods that should appear in the DLL must be decorated with Standard_EXPORT. In OCE, some class methods are not exported and therefore we can not wrap them. This fix disables all problematic classes and methods. Fixes issue tpaviot#14 and fixes tpaviot/pythonocc-core#93
rainman110
force-pushed
the
ms/fix_windows_build
branch
from
ae50f41
to
8469c38
Compare
|
Removed the commit with the quote replacements. |
tpaviot
added a commit
that referenced
this pull request
Dec 8, 2015
Disable wrapping of non-exported methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, all methods that should appear in the
DLL must be decorated with Standard_EXPORT. In OCE,
some class methods are not exported and therefore
we can not wrap them. This fix disables all problematic
classes and methods.
Fixes issue #14 and fixes tpaviot/pythonocc-core#93