Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution Guideline #13

Closed
abtonc opened this issue Apr 12, 2023 · 2 comments · Fixed by #38
Closed

Contribution Guideline #13

abtonc opened this issue Apr 12, 2023 · 2 comments · Fixed by #38

Comments

@abtonc
Copy link

abtonc commented Apr 12, 2023

I would love to contribute but I think a proper contribution guideline is needed for the future.

@tpecholt
Copy link
Owner

tpecholt commented Apr 13, 2023 via email

@JustCallMeRay
Copy link
Contributor

Can't speak for Arda but I would like to change the header extensions to .hpp (rather than .h) and change the cmake files to use find_package so I can use a package manager like Conan.

I think the need for a contributing guide is required even if it is just a "do the usual" in a couple of sentences. The main thing I find helpful is a merge request template and something that tells me what branch to merge into/base a pr off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants