Job payloads may implement #max_attempts to control how many times th…

…ey are retried

lib/delayed/backend/base.rb

@@ -85,6 +85,10 @@ def reschedule_at
           payload_object.reschedule_at(self.class.db_time_now, attempts) :
           self.class.db_time_now + (attempts ** 4) + 5
       end
+
+      def max_attempts
+        payload_object.max_attempts if payload_object.respond_to?(:max_attempts)
+      end
 
     private
 

lib/delayed/worker.rb

@@ -132,7 +132,7 @@ def run(job)
     # Reschedule the job in the future (when a job fails).
     # Uses an exponential scale depending on the number of failed attempts.
     def reschedule(job, time = nil)
-      if (job.attempts += 1) < self.class.max_attempts
+      if (job.attempts += 1) < max_attempts(job)
         job.run_at = time || job.reschedule_at
         job.unlock
         job.save!
@@ -154,6 +154,10 @@ def say(text, level = Logger::INFO)
       logger.add level, "#{Time.now.strftime('%FT%T%z')}: #{text}" if logger
     end
 
+    def max_attempts(job)
+      job.max_attempts || self.class.max_attempts
+    end
+
   protected
 
     def handle_failed_job(job, error)

spec/backend/shared_backend_spec.rb

@@ -299,4 +299,19 @@ def create_job(opts = {})
       @job.id.should_not be_nil
     end
   end
+
+  context "max_attempts" do
+    before(:each) do
+      @job = described_class.enqueue SimpleJob.new
+    end
+
+    it 'should not be defined' do
+      @job.max_attempts.should be_nil
+    end
+
+    it 'should use the max_retries value on the payload when defined' do
+      @job.payload_object.stub!(:max_attempts).and_return(99)
+      @job.max_attempts.should == 99
+    end 
+  end
 end

spec/sample_jobs.rb

@@ -15,6 +15,7 @@ def perform; sleep 250; end
 class OnPermanentFailureJob < SimpleJob
   def on_permanent_failure
   end
+  def max_attempts; 1; end
 end
 
 module M

spec/worker_spec.rb

@@ -165,7 +165,7 @@ def job_create(opts = {})
 
             it "should run that hook" do
               @job.payload_object.should_receive :on_permanent_failure
-              Delayed::Worker.max_attempts.times { @worker.reschedule(@job) }
+              @worker.reschedule(@job)
             end
           end