Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove use of 'which' to check for existence of gdbus-codegen. #800

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

flihp
Copy link
Contributor

@flihp flihp commented Dec 22, 2021

This is a redundant check. AC_CHECK_PROG already finds the program on
path and ensures that it is executable.

Signed-off-by: Philip Tricca flihp@twobit.org

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #800 (11eea81) into master (fd26bde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #800   +/-   ##
=======================================
  Coverage   79.63%   79.63%           
=======================================
  Files          32       32           
  Lines        3722     3722           
=======================================
  Hits         2964     2964           
  Misses        758      758           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd26bde...11eea81. Read the comment docs.

@flihp
Copy link
Contributor Author

flihp commented Dec 28, 2021

Updated after adding an entry in the CHANGELOG.

Copy link
Member

@williamcroberts williamcroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a redundant check. AC_CHECK_PROG already finds the program on
path and ensures that it is executable.

Signed-off-by: Philip Tricca <flihp@twobit.org>
@flihp flihp merged commit 7ea52a7 into tpm2-software:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants