Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Design Documents #8

Closed
williamcroberts opened this issue Sep 21, 2018 · 4 comments
Closed

Add Design Documents #8

williamcroberts opened this issue Sep 21, 2018 · 4 comments
Assignees
@idesai
Labels
enhancement New feature or request
Milestone
1.0

Comments

@williamcroberts
Copy link
Member

Add design documents and diagrams.
@williamcroberts williamcroberts self-assigned this Sep 26, 2018
@williamcroberts williamcroberts added the enhancement New feature or request label Sep 26, 2018
@williamcroberts williamcroberts mentioned this issue Oct 9, 2018
Merged
@nagesh20 nagesh20 mentioned this issue Nov 5, 2018
Closed
@PeterHuewe
Copy link
Contributor

Would be good to have more information on the objects, TPM keys and their types and attributes.

@williamcroberts williamcroberts added this to the alpha milestone Mar 28, 2019
@williamcroberts williamcroberts mentioned this issue Jul 11, 2019
Closed
@williamcroberts
Copy link
Member Author

Fixed in #265, however it needs an update to remove secondary object and wrapping object.

@williamcroberts
Copy link
Member Author

so docs/ARCHITECTURE.md is gone, so now we have @idesai doc:
https://github.com/tpm2-software/tpm2-pkcs11/blob/master/docs/tpm2-pkcs11_object_auth_model.md

Which is very close to correct. @idesai the wrapping object is gone, we just use a sealed AES key. So all wrapping/unwrapping occurs within library, not TPM. Since we release a secret, that is either the key or a password to a key, might as well just release a key, it doesn't change the attack.

@idesai can you update your doc when you get a chance?

@williamcroberts williamcroberts modified the milestones: alpha, 1.0 Nov 7, 2019
@williamcroberts
Copy link
Member Author

williamcroberts commented Dec 13, 2019 •
edited

Added back the ARCHITECTURE.md doc to breifly describe whats going on:
https://github.com/tpm2-software/tpm2-pkcs11/blob/master/docs/ARCHITECTURE.md

@williamcroberts williamcroberts mentioned this issue Apr 1, 2020
Merged
williamcroberts pushed a commit to williamcroberts/tpm2-pkcs11 that referenced this issue Jul 17, 2020
lib/tpm: fix double free of tpm cache pointers
7814d0b 
Fix free'ing an already free'd cache pointer by reseating the pointer to
NULL. This indicates that the cache needs to be recreated.

Fixes:
==29549==ERROR: AddressSanitizer: attempting double-free on 0x61900002cb80 in thread T0:
    #0 0x55e4a0ee56fd in free (/home/wcrobert/workspace/tpm2-pkcs11/test/integration/.libs/pkcs-initialize-finalize.int+0xb16fd)
    tpm2-software#1 0x7f6acc0922c2 in Esys_Free /home/wcrobert/workspace/tpm2-tss/src/tss2-esys/esys_free.c:16
    tpm2-software#2 0x55e4a0f4c590 in tpm_destroy /home/wcrobert/workspace/tpm2-pkcs11/src/lib/tpm.c:3261:5
    tpm2-software#3 0x55e4a0f2b6a4 in general_finalize /home/wcrobert/workspace/tpm2-pkcs11/src/lib/general.c:272:5
    tpm2-software#4 0x55e4a0f1a0ca in C_Finalize /home/wcrobert/workspace/tpm2-pkcs11/src/pkcs11.c:379:5
    tpm2-software#5 0x55e4a0f15d7a in test_double_calls /home/wcrobert/workspace/tpm2-pkcs11/test/integration/pkcs-initialize-finalize.int.c:260:10
    tpm2-software#6 0x55e4a0f15d7a in main /home/wcrobert/workspace/tpm2-pkcs11/test/integration/pkcs-initialize-finalize.int.c:269:5
    tpm2-software#7 0x7f6aca001b96 in __libc_start_main /build/glibc-2ORdQG/glibc-2.27/csu/../csu/libc-start.c:310
    tpm2-software#8 0x55e4a0e6da79 in _start (/home/wcrobert/workspace/tpm2-pkcs11/test/integration/.libs/pkcs-initialize-finalize.int+0x39a79)

Signed-off-by: William Roberts <william.c.roberts@intel.com>
williamcroberts pushed a commit that referenced this issue Jul 21, 2020
lib/tpm: fix double free of tpm cache pointers
5d7879a 
Fix free'ing an already free'd cache pointer by reseating the pointer to
NULL. This indicates that the cache needs to be recreated.

Fixes:
==29549==ERROR: AddressSanitizer: attempting double-free on 0x61900002cb80 in thread T0:
    #0 0x55e4a0ee56fd in free (/home/wcrobert/workspace/tpm2-pkcs11/test/integration/.libs/pkcs-initialize-finalize.int+0xb16fd)
    #1 0x7f6acc0922c2 in Esys_Free /home/wcrobert/workspace/tpm2-tss/src/tss2-esys/esys_free.c:16
    #2 0x55e4a0f4c590 in tpm_destroy /home/wcrobert/workspace/tpm2-pkcs11/src/lib/tpm.c:3261:5
    #3 0x55e4a0f2b6a4 in general_finalize /home/wcrobert/workspace/tpm2-pkcs11/src/lib/general.c:272:5
    #4 0x55e4a0f1a0ca in C_Finalize /home/wcrobert/workspace/tpm2-pkcs11/src/pkcs11.c:379:5
    #5 0x55e4a0f15d7a in test_double_calls /home/wcrobert/workspace/tpm2-pkcs11/test/integration/pkcs-initialize-finalize.int.c:260:10
    #6 0x55e4a0f15d7a in main /home/wcrobert/workspace/tpm2-pkcs11/test/integration/pkcs-initialize-finalize.int.c:269:5
    #7 0x7f6aca001b96 in __libc_start_main /build/glibc-2ORdQG/glibc-2.27/csu/../csu/libc-start.c:310
    #8 0x55e4a0e6da79 in _start (/home/wcrobert/workspace/tpm2-pkcs11/test/integration/.libs/pkcs-initialize-finalize.int+0x39a79)

Signed-off-by: William Roberts <william.c.roberts@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idesai idesai

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@PeterHuewe @idesai @williamcroberts