Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running rake through zeus if it is present and running #30

Closed
wants to merge 1 commit into from

Conversation

jacaetevha
Copy link

I don't know how useful this is for anyone else, but I use Zeus with my Rails apps. This will allow Rake to run much faster if Zeus is started. I check both for the existence of .zeus.sock and a running process because if the machine crashes .zeus.sock will still exist, even though Zeus isn't running, and it's not useful to check for a running process if the file doesn't exist at all.

@tpope
Copy link
Owner

tpope commented Jul 22, 2014

Isn't zeus on its way out and spring on its way in? Seems like a lot of code to support a dying tool.

@jacaetevha
Copy link
Author

My experience with Spring hasn't been a happy one, which is why I still use Zeus. But, feel free to ignore the PR.

@tpope
Copy link
Owner

tpope commented Jul 23, 2014

Yeah, the convolution of the process list search kills it for me.

@tpope tpope closed this Jul 23, 2014
@benjie
Copy link

benjie commented Aug 8, 2014

@tpope Would you accept it without the zeus_running? check? That only protects against zeus crashing and not cleaning up after itself. Besides that code only runs if the .zeus.sock file exists.

@tpope
Copy link
Owner

tpope commented Aug 8, 2014

Unlikely, but maybe if you can provide substantive answers to:

  1. Why Spring is unacceptable.
  2. Why you can't hack up some binstubs to call Zeus automatically.

@jacaetevha
Copy link
Author

  1. Spring gets into wonky states for me and I can't do anything, or it doesn't reflect my changes. Either way, I have to restart it much more frequently than Zeus.
  2. Why hack some binstubs when I can have it built into hookup? Maybe I'm misunderstanding. The thing is that I want hookup to be faster at what it does when I switch to the directory.

Having said all of that, I'm happy to use my own branch.

tpope added a commit that referenced this pull request Aug 9, 2014
References #30.
@tpope
Copy link
Owner

tpope commented Aug 9, 2014

2 could be inverted as "why send pull requests to every Rails tooling project you use when you could just solve it centrally once and for all?" Plus, the binstub gives you the benefit of not having to remember to type zeus, something no pull request can get you.

I've added and removed support for various preloaders to rails.vim as they've risen and fallen, so I know there's a cost to be paid here, however small. I'll begrudgingly merge with the following changes.

  1. Drop the aforementioned running check.
  2. Fix the commit message, so I don't have to rewrite it when I do release notes.
  3. Drop the zeus? indirection, as it's just one more thing I have to delete if the situation changes.
  4. Use File.socket?

@jacaetevha
Copy link
Author

No need to merge. Was just trying to answer your questions. I'm perfectly happy to use my own branch. Your points are well taken and fully understood.

cbartlett pushed a commit to cbartlett/hookup that referenced this pull request Apr 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants