Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using winfixwidth #453

Closed
keith opened this issue Mar 25, 2014 · 7 comments
Closed

Consider using winfixwidth #453

keith opened this issue Mar 25, 2014 · 7 comments

Comments

@keith
Copy link

keith commented Mar 25, 2014

When using :Gblame if you have winminwidth and winwidth settings when you switch splits you end up with a blame view that looks like this:
screen shot 2014-03-25 at 12 10 57 pm

This is fixed by setting winfixwidth on the blame window after it's opened. Should this happen by default? I'm not sure if there are any disadvantages here. This could also be useful for some of the other commands, although blame is the one I use the most.

@keith
Copy link
Author

keith commented Mar 25, 2014

In the meantime I have added this by using:

autocmd FileType fugitiveblame setlocal winfixwidth

@qstrahl
Copy link
Contributor

qstrahl commented Mar 25, 2014

Does this interfere with the commands that resize the blame window at all?

On 25 March 2014 12:14, Keith Smiley notifications@github.com wrote:

In the meantime I have added this by using:

autocmd FileType fugitiveblame setlocal winfixwidth

Reply to this email directly or view it on GitHubhttps://github.com//issues/453#issuecomment-38585150
.

@keith
Copy link
Author

keith commented Mar 25, 2014

What commands do you mean? You can still resize the window manually.

@tpope
Copy link
Owner

tpope commented Mar 25, 2014

I'm willing to give it a try. Can you confirm adding 'winfixwidth' to the big old setlocal in s:Blame() does the job?

@keith
Copy link
Author

keith commented Mar 25, 2014

It does. If you'd like I can submit the PR for this.

@tpope
Copy link
Owner

tpope commented Mar 25, 2014

Nah was already done, just didn't have time to test.

@tpope tpope closed this as completed in fd297ad Mar 25, 2014
@keith
Copy link
Author

keith commented Mar 25, 2014

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants