#1680 : Safety when window is closed during ReloadTabStatus reload loop

[ianhomer]

Candidate fix for #1680

[tpope]

This looks to me like it could still fail if you have 2 status windows open in the same tab. My preferred solution would be to change to a while loop, so that tabpagewinnr(tab, '$') is recomputed each time.

let winnr = 1
while winnr <= tabpagewinnr(tab, '$')
  " ...
  let winnr += 1
endwhile

There's still an edge case in that we could silently skip over a second status window if it moves out from under us, but I'm willing to live with that.

A true fix would utilize get_winid() to get a persistent reference to each window, but I'd rather wait till after dropping Vim 7 compatibility to roll that out.

[ianhomer]

Yep - that's better. I've updated branch as you suggest and verified it fixes issue described in #1680