Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --filters in cat-file whenever possible #1837

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Use --filters in cat-file whenever possible #1837

merged 1 commit into from
Sep 13, 2021

Conversation

YorikSar
Copy link
Contributor

Starting with Git 2.11 cat-file provides --filters option that can be
specified instead of "blob" type. This option tells Git to use all
filters specified in .gitattributes.

This enables diffs for files with filters, for example, git-crypt.

Closes #1509

Starting with Git 2.11 cat-file provides --filters option that can be
specified instead of "blob" type. This option tells Git to use all
filters specified in .gitattributes.

This enables diffs for files with filters, for example, git-crypt.

Closes #1509
@YorikSar YorikSar mentioned this pull request Sep 13, 2021
@tpope tpope merged commit 630ecc8 into tpope:master Sep 13, 2021
@justinmk
Copy link
Contributor

justinmk commented Sep 14, 2021

This option tells Git to use all filters specified in .gitattributes.

Is this a security risk, i.e. should it be an explicit opt-in per repository? I suppose some :Git commands could be considered "opt in" by virtue of their usage, but not others which are normally read-only.

edit: Looks like .gitattributes does not specify commands itself. It only points to aliases defined in ~/.git/config. So this seems fine.

@tpope
Copy link
Owner

tpope commented Sep 14, 2021

Correct, not a security risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git-crypt support?
3 participants