Tighten match for commit under cursor #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `coo` to open a branch under the cursor that started with 4+ hex digits (e.g., 1111-feat) would fail with the error `fatal: invalid reference: 1111.` This happened because the prior regex would consider these branch names as commits when determining whether to treat what was under the cursor as a branch or commit. This changes the regex to use a negative look-ahead to further tighten the match for a commit and require that a match on 4+ hex digits also not end with a non-hex digit. Resolves tpope#2085.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
cooto open a branch under the cursor that started with 4+ hexdigits (e.g., 1111-feat) would fail with the error
fatal: invalid reference: 1111.This happened because the prior regex would consider these branch names
as commits when determining whether to treat what was under the cursor
as a branch or commit.
This changes the regex to use a negative look-ahead to further tighten
the match for a commit and require that a match on 4+ hex digits also
not end with a non-hex digit.
Resolves #2085.