Fix :Gbrowse in "detached HEAD" state #730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code is slated to be replaced by rhubarb.vim going forward. I've backported all changes from there which appears to solve the problem. I'm not sure how I feel about the tag matching behavior. It's definitely useful but I think I might prefer something a bit more explicit. One thing I can say for sure is that it needs to live in |
wadkar
pushed a commit
to wadkar/vim-fugitive
that referenced
this pull request
Dec 16, 2015
brendeschuijmert
pushed a commit
to brendeschuijmert/vim-fugitive
that referenced
this pull request
Aug 6, 2019
brendeschuijmert
added a commit
to brendeschuijmert/vim-fugitive
that referenced
this pull request
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #646.
This patch tries to find the right URL for HEAD when in detached HEAD state. If there's a matching tag on HEAD (e.g.
git checkout v2.2) it will use it, otherwise, SHA. This is my attempt to fix the issue without fully understanding the codebase, so maybe I'm doing something incredibly wrong here and if there's a better way to handle this, feel free to close this PR. Actually I couldn't figure out what^\d\=$is supposed to match, but I noticed that it matches empty string in detached HEAD state.