Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repeat work when adding html/xml tags #31

Closed
wants to merge 1 commit into from
Closed

Make repeat work when adding html/xml tags #31

wants to merge 1 commit into from

Conversation

changemewtf
Copy link

modify repeat#set call to make '.' work as expected when adding html/xml tags

@tpope
Copy link
Owner

tpope commented Jun 13, 2011

This breaks . on everything that's not an HTML/XML tag.

If/when you fix this, please squash to a single commit and use a conventional commit message.

@seanfarley
Copy link

Would this explain why not just yst but also cst and dst are not currently working for HTML/XML?

@tpope
Copy link
Owner

tpope commented Dec 7, 2011

@seanfarley cst and dst should work fine. It's adding, not deleting, a tag that's broken.

@seanfarley
Copy link

@tpope Wow, sorry, yeah, epic fail on my part.

@moll
Copy link

moll commented Feb 29, 2012

Any progress on this?

@tpope tpope mentioned this pull request Mar 14, 2012
Closed
@tpope
Copy link
Owner

tpope commented Mar 14, 2012

Solved in 09fd529.

@tpope tpope closed this Mar 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@changemewtf @tpope @seanfarley @moll