[1.21] Placing a sign crashes the server #60
Labels
bug
Something isn't working
Comments
|
While looking for the cause of this bug, I was able to narrow the issue down to this line: I am not an expert in this, but I assume this happens because The constructor of Commenting that line out seemed to solve the issue without any side effects, but I don't know if this is actually the correct solution. |
|
Thank you for this report and the debugging. I'll take a look and get an update out soon. |
bleuthoot-sven
changed the title
tpwalke2
added a commit
that referenced
this issue
Jul 25, 2024
tpwalke2
added a commit
that referenced
this issue
Jul 25, 2024
#60 Use thread-safe constructor for SignManager
|
Unfortunately, I was unable to reproduce this. It seems like a race condition, however. I changed the SignManager singleton to be explicitly thread-safe instead of attempting to rely on the Java static initialization. Here's an alpha release with that update: https://modrinth.com/mod/bluemap-sign-markers/version/1.21.1-0.3.4.24-alpha |
|
I tried it again on a clean server, with only bluemap, fabric-api and the new version of bluemap-sign-markers installed. I still have the same issue that the server crashes, but the error message is different from last time: Crash reportEDIT: Also tested it on my server instance (which has a similar, but not the same hardware configuration) Server crash report |
|
Thank you for these crash reports. I'll keep digging. |
tpwalke2
added a commit
that referenced
this issue
Jul 26, 2024
tpwalke2
added a commit
that referenced
this issue
Jul 26, 2024
#60 Decouple SignManager and BlueMapAPIConnector through listener
|
The latest crash reports indicated an infinite recursion that Java eventually stopped with the StackOverflowError. Similar to the previous error, I was unable to replicate the error, but I could see how it could happen with the way that the constructors were coupled. I decoupled the constructors and published the alpha release here: https://modrinth.com/mod/bluemap-sign-markers/version/1.21.1-0.3.5.25-alpha |
|
Seems to work fine now. Both my personal system and my server don't crash anymore when placing signs.
I find it very interesting that you were not able to replicate it, while I was able to replicate it on two different systems. Maybe related to the processors I was using? Oh well, it is solved now. I think I will try to test it on some other systems I have with the older versions to see if it is a processor specific issue. Seems very unlikely, but it's worth a try. Thanks for solving this very weird issue. |
|
I noticed in the crash report that you are using version 21.0.4 of the Eclipse Adoptium OpenJDK. I have 21.0.3 installed. I'm also on an Intel x64 processor. It would have been more satisfying to replicate it locally, but I'm glad to hear that it's resolved now. Thank you for the excellent troubleshooting info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
When I place as sign, the server crashes completely.
Steps to reproduce
Crashlog
The text was updated successfully, but these errors were encountered: