Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: add --manpath option #629

Merged
merged 4 commits into from
Oct 20, 2018
Merged

CLI: add --manpath option #629

merged 4 commits into from
Oct 20, 2018

Conversation

casperdcl
Copy link
Sponsor Member

@casperdcl casperdcl commented Oct 16, 2018 •
edited
Loading

TODO

  • remove tqdm.1 from setup.py data_files
  • add CLI option --manpath to install man page to specified location
    • maybe add setuptools option as well
  • generate said documentation on-the-fly

@casperdcl casperdcl added p0-bug-critical ☢ Exception rasing p3-enhancement 🔥 Much new such feature to-fix ⌛ In progress labels Oct 16, 2018
@casperdcl casperdcl self-assigned this Oct 16, 2018
@casperdcl casperdcl added this to the v5.0.0 milestone Oct 16, 2018
@codecov-io
Copy link

Codecov Report

Merging #629 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #629   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          10       10           
  Lines         731      731           
  Branches      130      130           
=======================================
  Hits          721      721           
  Misses          6        6           
  Partials        4        4

@jgsogo jgsogo mentioned this pull request Oct 18, 2018
Closed
@casperdcl casperdcl merged commit 64bbcf3 into master Oct 20, 2018
casperdcl added a commit that referenced this pull request Oct 20, 2018
@casperdcl
bump version, CLI:add --manpath
f6448c1 
Merge branch 'man'

- fixes #460
- fixes #628
- closes #629
@casperdcl casperdcl deleted the man branch October 20, 2018 21:39
@danimtb
Copy link

danimtb commented Oct 22, 2018

I think this was fixed in 4.28.0, right?

@casperdcl
Copy link
Sponsor Member Author

yes, thought I'd recommend 4.28.1 instead

@casperdcl casperdcl changed the title CLI: add --man-path option CLI: add --manpath option Oct 22, 2018
@casperdcl casperdcl mentioned this pull request Dec 28, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@casperdcl casperdcl

Labels
p0-bug-critical ☢ Exception rasing p3-enhancement 🔥 Much new such feature to-fix ⌛ In progress
Projects
None yet
Milestone
Non-breaking
Development

Successfully merging this pull request may close these issues.

installation failure Install fails for >=4.19.1 (permission denied /usr/local/man)
3 participants
@casperdcl @codecov-io @danimtb