Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dedent calls by dedented strings. #837

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 7, 2019

The strings are so short that just using plain dedented literal strings
is just as readable (if not more) than going through dedent(), and this
change saves a call to a not-so-trivial function.

  • I have marked all applicable categories:
    • exception-raising fix
    • visual output fix
    • documentation modification
    • new feature
  • If applicable, I have mentioned the relevant/related issue(s)

Less important but also useful:

  • I have visited the source website, and in particular
    read the known issues

  • I have searched through the issue tracker for duplicates

  • I have mentioned version numbers, operating system and
    environment, where applicable:

    import tqdm, sys
    print(tqdm.__version__, sys.version, sys.platform)
    4.37.0 3.7.5 (default, Oct 25 2019, 15:51:11) 
    [GCC 7.3.0] linux
    

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #837 into devel will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            devel     #837      +/-   ##
==========================================
- Coverage   85.23%   85.17%   -0.06%     
==========================================
  Files          15       15              
  Lines         989      985       -4     
  Branches      173      171       -2     
==========================================
- Hits          843      839       -4     
  Misses        140      140              
  Partials        6        6

@casperdcl casperdcl self-assigned this Nov 7, 2019
@casperdcl casperdcl added to-merge ↰ Imminent p1-bug-perf ⚡ Speed suboptimal labels Nov 7, 2019
@casperdcl casperdcl added this to the v5.0.0 milestone Nov 7, 2019
@casperdcl casperdcl changed the base branch from master to devel November 21, 2019 22:43
short literals are faster and more readable than using dedent()

Co-authored by: Casper da Costa-Luis <tqdm@caspersci.uk.to>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-bug-perf ⚡ Speed suboptimal to-merge ↰ Imminent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants