Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

検索オプションの説明文に例を追加 #4095

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

mehm8128
Copy link
Member

close #3612

@mehm8128 mehm8128 self-assigned this Oct 17, 2023
@github-actions
Copy link

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

{ insertQuery: 'after:', description: '特定の日時以降のメッセージを検索' }
{
insertQuery: 'in:',
description: 'チャンネル名を指定して検索。例) in:general'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

。が入ってるのが個人的にあまり好きじゃないです 😕
プレースホルダ―みたいな形で別色で書くのとかだとどうですか(デザイン相談?)
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slackはそれっぽい補完を出してくれる
ここまでやらなくていいけどin:押したらクエリにプレースホルダー出てくるとかでもうれしいかも
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文字小さくして、色も変えたのと色は変えなかったのです
どっちがいいですかね
このどっちかでよさそうならプレースホルダーまでは出さなくていいかなと思ってます

image
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前者はちょっと見づらいかなーって思ってます

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自分もどちらかと言えば後者だけどなんとも言えず

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こんな感じになりました
右に隙間あったやつはスクロールバーが現れることがあるのでその分を取ってあったっぽいのですが、消してもそんなに体験悪くならなさそうなので消してよさそうです
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!あざます!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここで一緒に直していいかわからないけど↓にしたい

  • 発言->投稿
  • メンション先の -> メンションされた (投稿した と合わせて)
  • より前/より後 or 以前/以降 に統一

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before/afterの文言はもう少しいい感じにしたいけど思いつかなかった

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既にちょっと直した部分あるのでそれも直しちゃいます

@mehm8128 mehm8128 requested a review from ras0q October 19, 2023 06:27
Copy link
Contributor

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehm8128 mehm8128 merged commit d2e27f3 into master Oct 24, 2023
11 checks passed
@mehm8128 mehm8128 deleted the feat/add_command_query_example branch October 24, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

検索のオプション欄のbeforeとafterの説明に入力例を併記してほしい
4 participants