add support for colorlight-i9+ board #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems your branch is out of date, with some conflict. |
|
Ok forgot to update the cloned repository on my side. colorlight-i9+ carrier board have no onboard jtag interface. Can only upload via ch347t that need an out of tree openocd. The module have accessible jtag pins. |
|
Hi, If you prefer I can fix and apply the patch manually. As you want Thanks! |
|
You can apply the patch manually. I agree with you, better leave cable name empty. |
|
Applied! Thanks @infphyny |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for adding colorlight i9+ via an ftdi 2232. I didn't change that much in Makefile and board.hpp. Maybe I did a mistake somewhere. Let me know and I will change the pull request.