Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not heavily tested patch for #13 #14 #15 #22

Closed
wants to merge 1 commit into from

Conversation

Orio91
Copy link

@Orio91 Orio91 commented Aug 16, 2012

I use Trac with Git and multiple repository and tried to make a patch to make the plugin works.

@nb
Copy link
Contributor

nb commented Aug 17, 2012

Hey, Orlo91, thank you for your patch!

A couple of things before we can merge it:

  • It would be great if those were separate commits.
  • Since you added a new database column, we should add it to the upgrade function, see upgrade_from_1_to_2() in db.php
  • We will need to change the revision column type to string, or we won't fix Doesn't work at all for git repos #13
  • I would very much prefer the old time and date format, though I agree with the change to localtime

@Orio91
Copy link
Author

Orio91 commented Aug 23, 2012

This is the first time I use GIt and Github and dig so deeply in a Trac plugin :) I will try to make the pull request cleaner :)
For the time/format, I got a Genshi UnicodeDecodeError. That is why I changed it. I don't why I got this error.

@nb
Copy link
Contributor

nb commented Aug 23, 2012

@Orio91, no problem :-)

Probably you got the error because your locale's encoding is different from UTF-8 and the date contained non-ASCII characters. Could you try a couple of things for me:

import locale
import time
print locale.getlocale()
print time.strftime('%b')

Thanks.

@Orio91
Copy link
Author

Orio91 commented Aug 23, 2012

Here

Python 2.6.6 (r266:84292, Dec 26 2010, 22:31:48) 
[GCC 4.4.5] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import locale
>>> import time
>>> print locale.getlocale()
(None, None)
>>> print time.strftime('%b')
Aug

But our Trac is running with mod_wsgi and

SetEnv trac.locale fr_FR.utf8

@nb
Copy link
Contributor

nb commented Aug 23, 2012

The unicode issue should be fixed in fce63fb. If you could test it, it would be awesome.

@Orio91
Copy link
Author

Orio91 commented Aug 24, 2012

Yup, it works. This month name is 'août' and it is printed correctly.

@nb
Copy link
Contributor

nb commented Aug 24, 2012

@Orio91 great to hear.

@nb nb closed this Sep 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants