Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better patch for #13, #14, #15 #24

Closed
wants to merge 3 commits into from

Conversation

Orio91
Copy link

@Orio91 Orio91 commented Sep 10, 2012

This one should be cleaner than #22 :)

@crayfishuk
Copy link

How can I copy this into my trac server to test -- am keen to use the code-commenting but need to have #14 fixed before we can use it in our team (multiple repositories!)

Thanks!

-Craig

(We're an SVN shop here - not had much git exposure, so be gentle :) )

@nb
Copy link
Contributor

nb commented Sep 18, 2012

@Orio91 thanks for the updated pull request, I will look into the code.

@crayfishuk you can download @Orio91's version of the plugin from here: https://github.com/Orio91/trac-code-comments-plugin/zipball/master_clean

@crayfishuk
Copy link

Can't assist with patches. However - upgrade from code_comments db v1 - v3 is broken. Fails with 'No such column: repository'. Suspect that the upgrade from 1->2 needs to not require 'repository' column in schema.

Fixed by:-

  • editing db.py to remove column 'repository' from schema (line 20)
  • Set db_version = 2
  • Run trac-admin upgrade
  • edit db.py to include 'repository'
  • Set db_version =3
  • Run trac-admin upgrade again.

All appears to be ok - will report if I have any problems during use. Thanks for quick response on this!!! Fab :)

pass
columns = [c.name for c in schema['code_comments'].columns]
cursor = db.cursor()
values = cursor.execute('PRAGMA INDEX_LIST(`code_comments`)')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not for mysql, could you please provide a solution for mysql?

Thanks

@nb
Copy link
Contributor

nb commented May 4, 2018

Thanks, @rjollos, you’re right that the plugin is not maintained and thanks for forking the plugin. Let us know if there is a better way to send users your way.

@nb nb closed this May 4, 2018
@rjollos
Copy link
Member

rjollos commented May 4, 2018

Let us know if there is a better way to send users your way.

@nb Would you be willing to transfer the repository to the trac-hacks GitHub org? That way we would get all the open issues and the URL would redirect to the new location.

If yes, just let me know and I'll setup so the repository can be transferred.

@rjollos
Copy link
Member

rjollos commented May 7, 2018

@nb Would you be willing to transfer the repository to the trac-hacks GitHub org? That way we would get all the open issues and the URL would redirect to the new location.

I recall now that we discussed in #53.

@nb
Copy link
Contributor

nb commented May 9, 2018

@rjollos, sure, transferring sounds good – let’s do it, let me know when you’re done with the setup and I will transfer it.

@rjollos
Copy link
Member

rjollos commented May 9, 2018

Thanks! You should receive an invite to join the trac-hacks organization. Accepting will allow you to execute these steps and transfer the repository.

@nb
Copy link
Contributor

nb commented May 9, 2018

@rjollos, unfortunately the transfer cannot be initiated, because of the https://github.com/trac-hacks/trac-code-comments-plugin-2 fork. From the docs:

The target account must not have a repository with the same name, or a fork in the same network.

Maybe you can delete the repo on GitHub, but save the comments locally and replay them on the new remote later when we transfer it?

@rjollos
Copy link
Member

rjollos commented May 9, 2018

Maybe you can delete the repo on GitHub, but save the comments locally and replay them on the new remote later when we transfer it?

Done. Thanks for sorting that out.

@nb
Copy link
Contributor

nb commented May 9, 2018

Moving repository to trac-hacks/trac-code-comments-plugin. This may take a few minutes.

Thanks for the patience and for saving the project, @rjollos 🎉💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants