Fix double broadcast with tch #1026
Conversation
|
@nathanielsimard I can confirm that the tests that were failing in my project, pass now 🚀 |
| @@ -190,17 +190,30 @@ impl<E: TchElement> IntTensorOps<Self> for LibTorch<E> { | |||
| lhs: TchTensor<i64, D>, | |||
| rhs: TchTensor<i64, D>, | |||
| ) -> TchTensor<i64, D> { | |||
| TchOps::div(lhs, rhs) | |||
| let copy = false; | |||
There was a problem hiding this comment.
What does this actually do? seems like you're just forcing the float div to be used?
I took out all the changes in this file, and the failing tests on my repo and here still pass
There was a problem hiding this comment.
Yeah somehow I had to update this for the CI, I cast the i64 tensor to a f64 tensor without copying the data since it seems there are problems with integer division with tch.
| @@ -30,6 +30,17 @@ mod tests { | |||
| assert_eq!(data_expected, data_actual); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_mul_broadcast_2_dims() { | |||
There was a problem hiding this comment.
do we care about adding a test for Int?
There was a problem hiding this comment.
I don't think it's necessary, even if tch supports it, in Burn we do not expose int matmul in our API
There was a problem hiding this comment.
This is a normal mul that is available to the int tensor, but theorically this test validates the broadcasting logic that is present for all binary operations.
@dcvz Can you validate it fixes the problem you have with diffuser-rs?