Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation and book sections on PyTorch import #1180

Merged
merged 3 commits into from Jan 29, 2024
Merged

Update documentation and book sections on PyTorch import #1180

merged 3 commits into from Jan 29, 2024

Conversation

antimora
Copy link
Collaborator

@antimora antimora commented Jan 26, 2024 •
edited

Pull Request Template

Checklist

  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1085

Changes

  1. Added new sections in the book
  2. Updated burn-import readme file
  3. Updated the main readme file
  4. Formatted the main readme file

Testing

Proofread the rendered version.

Luni-4
Luni-4 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine for me! Thanks for your work!

Since I'm not a native English speaker, I've focused my review on semantics. I have only three doubts, but nothing blocking

burn-import/README.md Outdated Show resolved Hide resolved
burn-book/src/import/pytorch-model.md Outdated Show resolved Hide resolved
burn-book/src/import/README.md Outdated Show resolved Hide resolved
laggui
laggui requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes in the comments, otherwise LGTM 🙂

burn-book/src/import/README.md Outdated Show resolved Hide resolved
burn-book/src/import/pytorch-model.md Outdated Show resolved Hide resolved
burn-import/README.md Outdated Show resolved Hide resolved
@antimora antimora requested a review from laggui January 26, 2024 18:37
nathanielsimard
nathanielsimard requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment, great job documenting the new feature 💪

burn-book/src/import/pytorch-model.md Outdated Show resolved Hide resolved
@nathanielsimard nathanielsimard merged commit 67ffa1e into tracel-ai:main Jan 29, 2024
@nathanielsimard nathanielsimard deleted the pytorch-import-docs branch January 29, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luni-4 Luni-4 Luni-4 approved these changes

@laggui laggui laggui approved these changes

@nathanielsimard nathanielsimard nathanielsimard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@antimora @laggui @Luni-4 @nathanielsimard