Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add tracespace core package #402

Merged
merged 1 commit into from
Jan 16, 2023
Merged

feat(core): add tracespace core package #402

merged 1 commit into from
Jan 16, 2023

Conversation

mcous
Copy link
Member

@mcous mcous commented Dec 27, 2022

This PR adds a new package - @tracespace/core - to take care of the logic that used to live in pcb-stackup and pcb-stackup-core.

Compared to the parser, plotter, and renderer, the core library understands that its input represents all the files related to a single PCB. It is also the new home for board shape determination.

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #402 (840e022) into v5 (d37eed5) will decrease coverage by 1.00%.
The diff coverage is 82.91%.

@@            Coverage Diff             @@
##               v5     #402      +/-   ##
==========================================
- Coverage   91.58%   90.57%   -1.01%     
==========================================
  Files          35       44       +9     
  Lines        4609     5349     +740     
  Branches      513      611      +98     
==========================================
+ Hits         4221     4845     +624     
- Misses        388      504     +116     
Impacted Files Coverage Δ
packages/core/src/index.ts 58.79% <58.79%> (ø)
packages/core/src/sort-layers.ts 69.56% <69.56%> (ø)
packages/parser/src/index.ts 98.73% <75.00%> (-1.27%) ⬇️
packages/core/src/read-file.ts 86.27% <86.27%> (ø)
packages/core/src/board-shape/index.ts 96.80% <96.80%> (ø)
packages/core/src/board-shape/fill-gaps.ts 96.96% <96.96%> (ø)
packages/core/src/board-shape/walk-paths.ts 100.00% <100.00%> (ø)
packages/core/src/determine-layer-types.ts 100.00% <100.00%> (ø)
packages/core/src/stringify-svg.ts 100.00% <100.00%> (ø)
packages/renderer/src/index.ts 100.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mcous mcous marked this pull request as ready for review January 15, 2023 22:49
@mcous mcous marked this pull request as draft January 15, 2023 23:47
Base automatically changed from v5-view_plotter to v5 January 16, 2023 00:14
@mcous mcous marked this pull request as ready for review January 16, 2023 00:15
@mcous mcous merged commit 4af10c9 into v5 Jan 16, 2023
@mcous mcous deleted the v5-view_core branch January 16, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant