Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli)!: rewrite CLI on new render pipeline #405

Merged
merged 4 commits into from
Jan 16, 2023
Merged

refactor(cli)!: rewrite CLI on new render pipeline #405

merged 4 commits into from
Jan 16, 2023

Conversation

mcous
Copy link
Member

@mcous mcous commented Jan 15, 2023

This PR rewrites the tracespace CLI to use the v5 render pipeline.

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #405 (54c95c7) into v5 (4af10c9) will increase coverage by 2.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v5     #405      +/-   ##
==========================================
+ Coverage   90.57%   93.09%   +2.51%     
==========================================
  Files          44       49       +5     
  Lines        5349     5590     +241     
  Branches      611      656      +45     
==========================================
+ Hits         4845     5204     +359     
+ Misses        504      386     -118     
Impacted Files Coverage Δ
packages/cli/src/index.ts 100.00% <100.00%> (ø)
packages/cli/src/output.ts 100.00% <100.00%> (ø)
packages/cli/src/parse.ts 100.00% <100.00%> (ø)
packages/cli/src/plot.ts 100.00% <100.00%> (ø)
packages/cli/src/render.ts 100.00% <100.00%> (ø)
packages/core/src/sort-layers.ts 100.00% <100.00%> (+30.43%) ⬆️
packages/plotter/src/bounding-box.ts 100.00% <0.00%> (+0.85%) ⬆️
packages/parser/src/index.ts 100.00% <0.00%> (+1.26%) ⬆️
packages/renderer/src/render.ts 71.32% <0.00%> (+7.69%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mcous mcous marked this pull request as ready for review January 15, 2023 22:51
@mcous mcous marked this pull request as draft January 15, 2023 23:47
@mcous mcous changed the title refactor(cli): rewrite CLI on new render pipeline refactor(cli)!: rewrite CLI on new render pipeline Jan 16, 2023
Base automatically changed from v5-view_core to v5 January 16, 2023 00:20
@mcous mcous marked this pull request as ready for review January 16, 2023 00:21
@mcous mcous merged commit 5f6598d into v5 Jan 16, 2023
@mcous mcous deleted the v5-view_cli branch January 16, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant