Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change e-mail message, dropdown menu and welcome message #1932

Merged
merged 2 commits into from Jun 18, 2019
Merged

Change e-mail message, dropdown menu and welcome message #1932

merged 2 commits into from Jun 18, 2019

Conversation

gbonaspetti
Copy link
Contributor

@gbonaspetti gbonaspetti commented Jun 17, 2019 •
edited by Skylsmoi

#1926

Checkpoints

The goal of this section is to help code reviewer to do required checks on this pull request. Please don't edit this list.
If one or more of these checkpoints are out of scope, please write below why they are.

  • Code is clear enoug
  • If there are FIXME in the code, then there are associated issues and issue is referenced in the FIXME
  • If there are TODO, NOTE or HACK in code, date and developer initials are present
  • Automated tests have been written (covering feature or non regression), or at least an issue has been created for test implementation

@gbonaspetti gbonaspetti self-assigned this Jun 17, 2019
@coveralls
Copy link

coveralls commented Jun 17, 2019 •
edited

Coverage Status

Coverage decreased (-0.002%) to 84.493% when pulling 26c5d58 on fix/1926__fix_header_problems_after_search into e917fef on develop.

Skylsmoi
Skylsmoi requested changes Jun 17, 2019
View reviewed changes
frontend/src/container/Header.jsx Outdated Show resolved Hide resolved
frontend/src/css/Header.styl Outdated Show resolved Hide resolved
@Skylsmoi Skylsmoi merged commit 0f599e2 into develop Jun 18, 2019
@Skylsmoi Skylsmoi deleted the fix/1926__fix_header_problems_after_search branch June 18, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylsmoi Skylsmoi Skylsmoi approved these changes

Assignees

@gbonaspetti gbonaspetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gbonaspetti @coveralls @Skylsmoi