Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[for 2.6.0] [#2239] Add unit tests to frontend #2240

Merged
merged 29 commits into from Jan 3, 2020
Merged

[for 2.6.0] [#2239] Add unit tests to frontend #2240

merged 29 commits into from Jan 3, 2020

Conversation

metzgegu
Copy link
Contributor

#2239

Checkpoints

The goal of this section is to help code reviewer to do required checks on this pull request. Please don't edit this list.
If one or more of these checkpoints are out of scope, please write below why they are.

  • Code is clear enough
  • If there are FIXME in the code, then there are associated issues and issue is referenced in the FIXME
  • If there are TODO, NOTE or HACK in code, date and developer initials are present
  • Automated tests have been written (covering feature or non regression), or at least an issue has been created for test implementation

@metzgegu metzgegu added the frontend issue related to frontend development / ux / ui / apps label Aug 20, 2019
@metzgegu metzgegu requested a review from Skylsmoi August 20, 2019 15:26
@metzgegu metzgegu self-assigned this Aug 20, 2019
@coveralls
Copy link

coveralls commented Aug 20, 2019 •
edited

Coverage Status

Coverage remained the same at 86.333% when pulling 16058fa on feature/2239__add_unit_tests_to_frontend into 5be593f on develop.

@PhilippeAccorsi PhilippeAccorsi changed the title [#2239] Add unit tests to frontend WIP [#2239] Add unit tests to frontend Sep 9, 2019
@PhilippeAccorsi PhilippeAccorsi changed the title WIP [#2239] Add unit tests to frontend [for tracim > 2.5.1] WIP [#2239] Add unit tests to frontend Nov 26, 2019
@PhilippeAccorsi PhilippeAccorsi changed the title [for tracim > 2.5.1] WIP [#2239] Add unit tests to frontend [for 2.6.0] WIP [#2239] Add unit tests to frontend Dec 13, 2019
@PhilippeAccorsi
Copy link
Collaborator

@Skylsmoi @metzgegu its necessary to merge before make new develoment for release 2.6.0

@metzgegu metzgegu marked this pull request as ready for review December 17, 2019 10:20
@metzgegu metzgegu changed the title [for 2.6.0] WIP [#2239] Add unit tests to frontend [for 2.6.0] [#2239] Add unit tests to frontend Dec 17, 2019
@metzgegu
[#2239] Remove comment to WorkspaceListItem.spec.js, this test doesn'…
7efd18a 
…t work and it is explained why in a comment
@metzgegu
Merge branch 'develop' of https://github.com/tracim/tracim into featu…
4a5ae6f 
…re/2239__add_unit_tests_to_frontend

� Conflicts:
�	frontend/test/fixture/user/globalManagerAsMember.js
�	frontend/test/src/component/WorkspaceListItem.spec.js
@metzgegu
[#2239] Resolve merge conflicts
7973504
@metzgegu metzgegu merged commit 06ff405 into develop Jan 3, 2020
@metzgegu metzgegu deleted the feature/2239__add_unit_tests_to_frontend branch January 3, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylsmoi Skylsmoi Skylsmoi approved these changes

Assignees

@metzgegu metzgegu

Labels
frontend issue related to frontend development / ux / ui / apps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@metzgegu @coveralls @PhilippeAccorsi @Skylsmoi