Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[for 2.5.1] [#2345] added error handling for file size limitation #2394

Merged

Conversation

Skylsmoi
Copy link
Collaborator

@Skylsmoi Skylsmoi commented Sep 11, 2019

#2345

Checkpoints

The goal of this section is to help code reviewer to do required checks on this pull request. Please don't edit this list.
If one or more of these checkpoints are out of scope, please write below why they are.

  • Code is clear enough
  • If there are FIXME in the code, then there are associated issues and issue is referenced in the FIXME
  • If there are TODO, NOTE or HACK in code, date and developer initials are present
  • Automated tests have been written (covering feature or non regression), or at least an issue has been created for test implementation

@Skylsmoi Skylsmoi self-assigned this Sep 11, 2019
@PhilippeAccorsi PhilippeAccorsi changed the title [#2345] added error handling for file size limitation [not for 2.4.0] [#2345] added error handling for file size limitation Sep 13, 2019
@coveralls
Copy link

coveralls commented Sep 16, 2019

Coverage Status

Coverage remained the same at 86.333% when pulling 9cee084 on fix/2345__add_frontend_error_handling_for_file_limit into be8ed68 on develop.

@PhilippeAccorsi PhilippeAccorsi changed the title [not for 2.4.0] [#2345] added error handling for file size limitation [for 2.5.1] [#2345] added error handling for file size limitation Nov 26, 2019
@lebouquetin
Copy link
Contributor

I fixed some typo

@PhilippeAccorsi PhilippeAccorsi merged commit 96d195b into develop Dec 5, 2019
@PhilippeAccorsi PhilippeAccorsi deleted the fix/2345__add_frontend_error_handling_for_file_limit branch December 5, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants