Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with embroider-addon blueprint #679

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Sync with embroider-addon blueprint #679

merged 1 commit into from
Jul 30, 2023

Conversation

SergeAstapov
Copy link
Collaborator

@SergeAstapov SergeAstapov commented Jul 25, 2023 •
edited

this makes CI green again.

@SergeAstapov SergeAstapov force-pushed the sync-embroider-addon-blueprint branch from 8ddc881 to c5e34fc Compare July 25, 2023 20:26
@SergeAstapov SergeAstapov mentioned this pull request Jul 25, 2023
Merged
chriskrycho
chriskrycho approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@chriskrycho chriskrycho merged commit d3db44e into main Jul 30, 2023
13 checks passed
@chriskrycho chriskrycho deleted the sync-embroider-addon-blueprint branch July 30, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

@nlfurniss nlfurniss Awaiting requested review from nlfurniss

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SergeAstapov @chriskrycho