Fix triple-slash reference in complied output, breaking TS consumers

[NullVoxPopuli]

Related fixes:

• https://github.com/jmurphyau/ember-truth-helpers/pull/188/files/ce510514b8af75e1dda509162190cced07bf1aee..b21676dacb9585ae4bb63d5e2cf0e9f5cb607d0f#diff-8afe3e4876b5c49d5ffaf6c8f18ae139f02686841982ca9b8ed2020dec8a8cd8
• Remove reference to EmberComponent to remove the triple-slash directive tildeio/ember-element-helper#113

Any import from @ember/component (or its subpaths), where @ember/component types are exposed in the declarations, ends up inserting /// <reference> entries at the top of the file.

This made upgrading to v1.0.2 of ember-async-data impossible for folks using any ember-source version that has a different set of types than the ember-source version that ember-async-data is developed with. (too new, no preview types, provided by stable. too old, no preview types, provided by @types/*).

Locally, to test, all you need to do is

yarn build
cat ember-async-data/declarations/helpers/load.d.ts

and observe that there are no triple-slash directives.

[SergeAstapov]

@NullVoxPopuli thank you for doing this here! Had the exact same thought.

@NullVoxPopuli one concern though about support:
readme currently says Ember.js v3.28 or above (requires Octane Edition) hence I assume we need to add ember-functions-as-helper-polyfill to avoid major release

[NullVoxPopuli]

hence I assume we need to add ember-functions-as-helper-polyfill to avoid major release

just added! thanks!

[chriskrycho]

If you do as suggested here and explicitly name the type, I believe you can drop the other changes here, which would be preferable for now. Switching to the plain function as helper can come in a later PR that way, and avoid introducing any other changes for this one TS fix. Do let me know if that doesn't work, though!

[SergeAstapov]

If you do as suggested here and explicitly name the type, I believe you can drop the other changes here, which would be preferable for now.

as per #705 it does not seem viable.

@chriskrycho updated this PR per the plan outlined in #705 (comment)

please let us know if this looks good to proceed or if you have any concerns. Thank you for suggestions and ideas here and in the other PR!

[SergeAstapov]

@chriskrycho per the plan outlined in #705 (comment), this is now ready to go if no concerns from your side and then we can publish v1.0.3

[NullVoxPopuli]

Made a tool to help out in the future: https://github.com/NullVoxPopuli/fix-bad-declaration-output

[chriskrycho]

🎉