Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ember-auto-import 2 to make CI green #154

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Use ember-auto-import 2 to make CI green #154

merged 1 commit into from
Oct 18, 2021

Conversation

SergeAstapov
Copy link
Contributor

This fixes the CI for beta/canary ember-try scenarios cc @chriskrycho

@SergeAstapov
Copy link
Contributor Author

@chriskrycho chriskrycho added breaking dependencies Pull requests that update a dependency file labels Oct 8, 2021
@chriskrycho
Copy link
Collaborator

  1. Thank you!
  2. Hmm, looks like it’s still failing the compatibility tests?

@SergeAstapov
Copy link
Contributor Author

@chriskrycho yes, but this time it's something different:

Template Compiler Error (TemplateCompiler) in dummy/templates/application.hbs

Cannot read property 'visitor' of undefined
ERROR Summary:

  - broccoliBuilderErrorStack: TypeError: Cannot read property 'visitor' of undefined
    at preprocess (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-source/dist/ember-template-compiler.js:12245:40)
    at normalize (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-source/dist/ember-template-compiler.js:12901:15)
    at precompileJSON (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-source/dist/ember-template-compiler.js:5402:47)
    at precompile (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-source/dist/ember-template-compiler.js:5435:31)
    at Object.precompile (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-source/dist/ember-template-compiler.js:19049:37)
    at TemplateCompiler.processString (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-cli-htmlbars/lib/template-compiler-plugin.js:68:55)
    at Object.processString (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-cli-htmlbars/node_modules/broccoli-persistent-filter/lib/strategies/default.js:7:32)
    at Processor.processString (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-cli-htmlbars/node_modules/broccoli-persistent-filter/lib/processor.js:16:31)
    at invoke (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-cli-htmlbars/node_modules/broccoli-persistent-filter/lib/index.js:84:21)
    at TemplateCompiler.processFile (/home/runner/work/tracked-maps-and-sets/tracked-maps-and-sets/node_modules/ember-cli-htmlbars/node_modules/broccoli-persistent-filter/lib/index.js:393:28)

and I'm quite puzzled what is that.

@chriskrycho please note this is not breaking change for users of this addon as it's in devDependencies.

@SergeAstapov
Copy link
Contributor Author

Fixes #121.

@SergeAstapov
Copy link
Contributor Author

@chriskrycho finally CI is green! I had to replace "ember-cli-template-lint": "^2.0.2" with ember-template-lint@3.

Latest ember-cli-template-lint depends on ember-template-lint@2 which seem to be breaking under Ember v4 and that was causing broccoliBuilderErrorStack: TypeError: Cannot read property 'visitor' of undefined error.

@SergeAstapov SergeAstapov changed the title Use ember-auto-import 2 per Ember.js 4 requirement Use ember-auto-import 2 to make CI green Oct 18, 2021
@chriskrycho chriskrycho merged commit 4a1d4de into tracked-tools:master Oct 18, 2021
@chriskrycho
Copy link
Collaborator

Latest ember-cli-template-lint depends on ember-template-lint@2 which seem to be breaking under Ember v4 and that was causing broccoliBuilderErrorStack: TypeError: Cannot read property 'visitor' of undefined error.

This is super helpful to know for tracking that down across the ecosystem. Thank you!

This was referenced Oct 18, 2021
@SergeAstapov SergeAstapov deleted the auto-import-2 branch October 18, 2021 21:13
@SergeAstapov
Copy link
Contributor Author

For the future travelers, more detailed explanation of the TypeError: Cannot read property 'visitor' of undefined issue can be found in emberjs/ember.js#19724 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants