Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAU: Fix issue with deployment #753

Merged
merged 1 commit into from
Jan 18, 2024
Merged

BAU: Fix issue with deployment #753

merged 1 commit into from
Jan 18, 2024

Conversation

amberstarlight
Copy link
Member

What?

I have added/removed/altered:

  • Added GOVUK_APP_DOMAIN env var (this is necessary for a gem we're not using).
  • Removed NewRelic things that aren't useful.

Why?

I am doing this because:

  • Deploys are failing silently because of this error

@amberstarlight amberstarlight self-assigned this Jan 18, 2024
jebw
jebw previously approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amberstarlight amberstarlight merged commit 9ca0594 into main Jan 18, 2024
15 checks passed
@amberstarlight amberstarlight deleted the bau-fix-deploys branch January 18, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jebw jebw jebw approved these changes

Assignees

@amberstarlight amberstarlight

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amberstarlight @jebw