Batch buy #18
Merged
Batch buy #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-3-7
force-pushed
the
feature/batch-buy
branch
from
376a19a
to
0a0a1ee
Compare
Max-3-7
commented
Jul 19, 2022
contracts/JoepegExchange.sol
Outdated
Comment on lines
263
to
274
| function _transferWAVAXIfNeeded(uint256 cost) internal { | ||
| // If not enough AVAX to cover the cost, use WAVAX | ||
| if (cost > msg.value) { | ||
| IERC20(WAVAX).safeTransferFrom( | ||
| msg.sender, | ||
| address(this), | ||
| (cost - msg.value) | ||
| ); | ||
| } else { | ||
| require(cost == msg.value, "Order: Msg.value too high"); | ||
| } | ||
| } |
There was a problem hiding this comment.
I moved the transfer WAVAX logic outside of _matchAskWithTakerBidUsingAVAXAndWAVAX because of require(takerBid.price == msg.value, "Order: Msg.value too high");
When you use batch buy with AVAX, you send more AVAX than the price of a single order so takerBid.price < msg.value
There was a problem hiding this comment.
Also moved IWAVAX(WAVAX).deposit{value: msg.value}(); for the same reason: you can only deposit msg.value once so it reverted in the batch buy for loop
0xnivek
reviewed
Jul 19, 2022
LouisMeMyself
suggested changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to let users buy multiple NFTs in a single transaction. This PR adds a simple function to JoepegExchange to execute multiple match orders call in a for loop.
Another option could be to use a payable multicall but i'm not sure to get all the security issues that may arise :gem smart contracts : https://etherscan.io/address/0x83c8f28c26bf6aaca652df1dbbe0e1b56f8baba2#code