Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two price scales #290

Merged
merged 55 commits into from
May 15, 2020
Merged

Two price scales #290

merged 55 commits into from
May 15, 2020

Conversation

eugene-korobko
Copy link
Contributor

@eugene-korobko eugene-korobko commented Dec 20, 2019 •
edited by timocov
Loading

Type of PR: enhancement

PR checklist:

Overview of change:
Now it is possible to show both left and rigth price axises.

timocov
timocov suggested changes Dec 25, 2019
View reviewed changes
Copy link
Contributor

@timocov timocov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add some test cases for that feature. I guess that there might be a lot of edge cases (some of them I've pointed in the comments) and we need to have tests for them.

src/gui/chart-widget.ts Outdated Show resolved Hide resolved
src/gui/chart-widget.ts Outdated Show resolved Hide resolved
src/gui/chart-widget.ts Outdated Show resolved Hide resolved
src/gui/chart-widget.ts Outdated Show resolved Hide resolved
src/gui/chart-widget.ts Outdated Show resolved Hide resolved
src/model/pane.ts Outdated Show resolved Hide resolved
src/model/pane.ts Outdated Show resolved Hide resolved
src/model/pane.ts Outdated Show resolved Hide resolved
src/model/series-options.ts Outdated Show resolved Hide resolved
src/model/series-options.ts Outdated Show resolved Hide resolved
timocov
timocov suggested changes Feb 4, 2020
View reviewed changes
src/api/chart-api.ts Outdated Show resolved Hide resolved
src/api/chart-api.ts Outdated Show resolved Hide resolved
src/api/chart-api.ts Outdated Show resolved Hide resolved
src/api/chart-api.ts Outdated Show resolved Hide resolved
src/model/series.ts Outdated Show resolved Hide resolved
src/model/pane.ts Outdated Show resolved Hide resolved
src/model/pane.ts Outdated Show resolved Hide resolved
src/model/pane.ts Outdated Show resolved Hide resolved
src/model/pane.ts Outdated Show resolved Hide resolved
src/model/pane.ts Show resolved Hide resolved
@timocov timocov assigned timocov and unassigned eugene-korobko Mar 4, 2020
@timocov timocov changed the title WIP: 129: two price scales Two price scales Mar 4, 2020
timocov
timocov suggested changes Mar 5, 2020
View reviewed changes
docs/series-basics.md Outdated Show resolved Hide resolved
src/api/chart-api.ts Outdated Show resolved Hide resolved
src/api/chart-api.ts Show resolved Hide resolved
src/model/pane.ts Outdated Show resolved Hide resolved
src/model/pane.ts Outdated Show resolved Hide resolved
docs/price-scale.md Outdated Show resolved Hide resolved
docs/price-scale.md Show resolved Hide resolved
docs/3.0-breaking-changes.md Outdated Show resolved Hide resolved
docs/3.0-breaking-changes.md Show resolved Hide resolved
docs/3.0-breaking-changes.md Show resolved Hide resolved
@timocov timocov removed their assignment Apr 3, 2020
@timocov timocov mentioned this pull request Apr 7, 2020
Merged
3 tasks
timocov
timocov suggested changes Apr 20, 2020
View reviewed changes
src/model/chart-model.ts Outdated Show resolved Hide resolved
src/model/series.ts Outdated Show resolved Hide resolved
@timocov timocov merged commit fe12297 into master May 15, 2020
@timocov timocov deleted the 129-two-price-axises branch May 15, 2020 09:13
@timocov timocov mentioned this pull request May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melroy89 melroy89 melroy89 approved these changes

@timocov timocov timocov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the second price axis
3 participants
@eugene-korobko @melroy89 @timocov