-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to search for documentation in repository root and in "./docs/" #4
Conversation
…r mkdocs.yml Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com> No need to duplicate the same information Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Some code can be simplify.
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
…nction Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
|
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Broken menu fixed, it was easy:
=> Validated on github.com/dduportal/traefik. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
OK, latest code works very well (on my fork :) ) for all of these scenarios:
|
This PR introduce the ability to search, build and manage documentation when it's located in the
./docs
sub directory.Please note that it fixes an issue coming from #2 (and currently on master): if
docs.Dockerfile
is found into./docs
, then the build fails ifrequirements.txt
is not next to it. But if we letmkdocs.yml
at the root of the repo (on the same version), it also requiresrequirements.txt
next to it.