Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Revamp #4475

Merged
merged 50 commits into from Feb 26, 2019
Merged

Conversation

geraldcroes
Copy link
Contributor

What does this PR do?

This PR is an attempt at revamping the documentation, and include recent changes on the architecture (notably middleware).

Motivation

We want people to spend more time on the disco dancefloor.

Additional Notes

Some sections are still work in progress (marked todo in the title), others are already reviewable.

We're aware that this is quite a huge PR ... and we're not even sorry for that.

(If it's OK, we'll rebase later since the history is not relevant)

Co-authored-by: jbdoumenjou jb.doumenjou@gmail.com

geraldcroes and others added 8 commits February 18, 2019 13:22
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor

FYI, to support this branch once it will be merged, a PR to structor had been sent: traefik/structor#4 .

Test scenarios (on my fork of course):

@dduportal
Copy link
Contributor

Everything is ready to go in structor, this PR can be merged from the point of view of the plumbing/tooling.

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit ac6b110 into traefik:master Feb 26, 2019
@ldez ldez deleted the feature/documentation branch February 26, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants