Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x arch docker image #22

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

rohitsakala
Copy link
Contributor

@rohitsakala rohitsakala commented Feb 22, 2022

S390x PR traefik/traefik#8729 is merged in Traefik

For Docker library images script to publish s390x docker image, this PR is necessary.

Fix #20

@ldez
Copy link
Member

ldez commented Feb 22, 2022

@rohitsakala
Copy link
Contributor Author

rohitsakala commented Feb 23, 2022

https://github.com/docker-library/official-images/#architectures-other-than-amd64

Hello @ldez , what I understood is that when Traefik releases a new version in Feb last week which will have support for s390x, the https://github.com/docker-library/official-images repo will be updated with new version and will add s390x to this line https://github.com/docker-library/official-images/blob/master/library/traefik#L11, then docker library scripts will run this Dockerfile https://github.com/traefik/traefik-library-image/blob/master/alpine/Dockerfile for all architectures. So, I made this PR.

Let me know if my understanding is wrong. Thanks :)

@ldez ldez self-requested a review February 23, 2022 09:38
@rohitsakala
Copy link
Contributor Author

Hi @ldez , any reviews on this ? Thanks

@rohitsakala
Copy link
Contributor Author

@ldez , docker still outputs s390x images in Jenkins - https://doi-janky.infosiftr.net/job/multiarch/job/s390x/

@ldez ldez added the kind/enhancement a new or improved feature. label Mar 7, 2022
@ldez
Copy link
Member

ldez commented Mar 22, 2022

We will manage the Docker part.

@traefiker traefiker merged commit 3abf28b into traefik:master Mar 22, 2022
@rohitsakala
Copy link
Contributor Author

Thanks @ldez . Please add s390x arch too in here https://github.com/docker-library/official-images/blob/master/library/traefik#L11 when upgrading traefik from v2.6.1 to v2.6.2 in here https://github.com/docker-library/official-images/blob/master/library/traefik#L10

@ldez
Copy link
Member

ldez commented Mar 22, 2022

We will manage the Docker part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add s390x arch support
3 participants