Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add s390x arch support #8729

Merged
merged 1 commit into from Feb 15, 2022
Merged

Add s390x arch support #8729

merged 1 commit into from Feb 15, 2022

Conversation

rohitsakala
Copy link
Contributor

@rohitsakala rohitsakala commented Jan 24, 2022 •
edited by kevinpollet

What does this PR do?

Add s390x arch support

Motivation

Increasing usage of Kubernetes on s390x.

Fixes #8728

@rohitsakala
Copy link
Contributor Author

@ldez Could you review this PR ? Thanks 😄

@rohitsakala rohitsakala mentioned this pull request Jan 25, 2022
Closed
6 tasks
@rtribotte rtribotte added this to To review in v2 via automation Jan 25, 2022
@ldez ldez self-requested a review January 25, 2022 14:35
@rohitsakala rohitsakala mentioned this pull request Jan 27, 2022
Closed
2 tasks
@tomMoulard tomMoulard linked an issue Jan 31, 2022 that may be closed by this pull request
Add s390x arch support #8728
Closed
2 tasks
@rohitsakala
Copy link
Contributor Author

rohitsakala commented Feb 1, 2022 •
edited by ldez

@ldez @tomMoulard @rtribotte Could you review this ? or allow running of Github checks as a first step.

Thanks 😄

@ldez ldez self-assigned this Feb 1, 2022
@rohitsakala
Copy link
Contributor Author

@ldez any update on this PR ?

@rohitsakala
Copy link
Contributor Author

@ldez All checks have passed. Can we merge ? Thanks

tomMoulard
tomMoulard approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@ldez ldez removed their assignment Feb 15, 2022
ldez
ldez approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the base branch from master to v2.6 February 15, 2022 08:47
@kevinpollet kevinpollet added this to the 2.6 milestone Feb 15, 2022
kevinpollet
kevinpollet approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit 9e96089 into traefik:v2.6 Feb 15, 2022
v2 automation moved this from To review to Done Feb 15, 2022
@rohitsakala rohitsakala mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@ldez ldez ldez approved these changes

@tomMoulard tomMoulard tomMoulard approved these changes

Assignees
No one assigned
Labels
area/infrastructure kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

Add s390x arch support
6 participants
@rohitsakala @kevinpollet @ldez @tomMoulard @rtribotte @traefiker