Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of SameSite settings for sticky session cookies #6261

Closed
mattyb opened this issue Jan 31, 2020 · 7 comments
Closed

Allow configuration of SameSite settings for sticky session cookies #6261

mattyb opened this issue Jan 31, 2020 · 7 comments
Assignees
@ldez
Labels
kind/enhancement a new or improved feature. priority/P1 need to be fixed in next release status/5-frozen-due-to-age
Projects
v2
Milestone
1.7

Comments

@mattyb
Copy link

mattyb commented Jan 31, 2020

Feature
With Chrome 80 going stable on Feb 4, 3rd party cookies without the SameSite=None setting will be blocked. https://blog.chromium.org/2019/10/developers-get-ready-for-new.html. In our testing, this breaks sticky sessions for services that are iframed into another page.

Relates to #2653, #4738
@mattyb
Copy link
Author

mattyb commented Jan 31, 2020

Also filed vulcand/oxy#192 which may be a dependency

@ldez ldez added kind/enhancement a new or improved feature. priority/P2 need to be fixed in the future and removed status/0-needs-triage labels Feb 3, 2020
@ldez ldez added this to issues in v2 via automation Feb 3, 2020
@umens
Copy link

umens commented Mar 20, 2020

Any updates on this ?

@MichaelErmer
Copy link
Contributor

This is breaking our websocket based api. Any news? its a massive bug

@ldez ldez assigned mpl and ldez and unassigned juliens and mpl Mar 20, 2020
@ldez ldez mentioned this issue Mar 21, 2020
Merged
@ldez
Copy link
Member

ldez commented Mar 21, 2020

I'm working on it, it will soon be corrected.

@ldez ldez added priority/P1 need to be fixed in next release and removed priority/P2 need to be fixed in the future labels Mar 21, 2020
This was referenced Mar 21, 2020
Merged
Merged
@traefiker traefiker added this to the 2.1 milestone Mar 23, 2020
@traefiker
Copy link
Contributor

Closed by #6538.

v2 automation moved this from issues to Done Mar 23, 2020
@traefiker traefiker modified the milestones: 2.1, 1.7 Mar 23, 2020
@traefiker
Copy link
Contributor

Closed by #6537.

@traefik traefik locked and limited conversation to collaborators Apr 28, 2020
tpayne84 added a commit to tpayne84/traefik that referenced this issue Dec 12, 2020
@tpayne84
In fix traefik#6261 that adds the ability to configure [ sameSite, ht…
b4072f9 
…tpOnly, secure ] cookie options... the template for service fabric did not receive updates and still does not support these options.

This change adds the support for the options noted above by adding entries for them into the service fabric template file.

Documentation has also been updated to include support for the added config values.
ldez pushed a commit to tpayne84/traefik that referenced this issue Jan 7, 2021
@tpayne84 @ldez
In fix traefik#6261 that adds the ability to configure [ sameSite, ht…
7987a61 
…tpOnly, secure ] cookie options... the template for service fabric did not receive updates and still does not support these options.

This change adds the support for the options noted above by adding entries for them into the service fabric template file.

Documentation has also been updated to include support for the added config values.
@traefiker
Copy link
Contributor

Closed by #7667.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ldez ldez

Labels
kind/enhancement a new or improved feature. priority/P1 need to be fixed in next release status/5-frozen-due-to-age
Projects
No open projects
v2
Done
Milestone
1.7
Development

No branches or pull requests
7 participants
@mattyb @juliens @mpl @MichaelErmer @umens @ldez @traefiker