Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sameSite (Traefik v2) #6538

Merged
merged 4 commits into from Mar 23, 2020
Merged

Fix sameSite (Traefik v2) #6538

merged 4 commits into from Mar 23, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 21, 2020 •
edited

What does this PR do?

Allow to configure cookie option:

  • sameSite

Motivation

Fixes #6261

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Waiting for vulcand/oxy#195

@ldez ldez added this to To review in v2 via automation Mar 21, 2020
@traefiker traefiker added this to the 2.2 milestone Mar 21, 2020
@ldez ldez changed the base branch from v2.2 to v2.1 March 22, 2020 09:35
@ldez ldez removed the bot/no-merge label Mar 22, 2020
@ldez ldez removed this from the 2.2 milestone Mar 22, 2020
@ldez ldez added this to the 2.1 milestone Mar 22, 2020
juliens
juliens approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur requested changes Mar 23, 2020
View reviewed changes
docs/content/routing/providers/docker.md Outdated Show resolved Hide resolved
docs/content/routing/providers/marathon.md Outdated Show resolved Hide resolved
docs/content/routing/providers/rancher.md Outdated Show resolved Hide resolved
@ldez @mmatur
Apply suggestions from code review
f3af272 
Co-Authored-By: Michael <mmatur@users.noreply.github.com>
mmatur
mmatur approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 0c28630 into traefik:v2.1 Mar 23, 2020
v2 automation moved this from To review to Done Mar 23, 2020
@traefiker traefiker mentioned this pull request Mar 23, 2020
Closed
@ldez ldez deleted the fix/v2-samesite branch March 23, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mpl mpl mpl approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/provider area/sticky-session kind/bug/fix a bug fix size/M
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mpl @mmatur @traefiker