New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor toolchain #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
- Add a Makefile with common targets (binary, test, validate, ..) - Use docker to build it (isolated) And update circleci to work with the new Makefile.. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Closed
while1eq1
pushed a commit
to while1eq1/traefik
that referenced
this pull request
Oct 9, 2017
Update from upstream repo containous/traefik
nemosupremo
added a commit
to nemosupremo/traefik
that referenced
this pull request
Dec 6, 2017
Sync vendor and glide.
1 task
apollo13
pushed a commit
to apollo13/traefik
that referenced
this pull request
Jan 22, 2021
Properly validate consul root CA.
apollo13
pushed a commit
to apollo13/traefik
that referenced
this pull request
Jan 22, 2021
use TLS to communicate with Consul Connect services
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly change the
Dockerfile
and theMakefile
and its targets to usedocker
for building. π§This also updates the
circleci.yml
file to make the continuous integration to work with it.The list of the current targets :
validate
(validate-gofmt
) : validates the projects files ; for now just checking ongofmt
but could be used with other tooling (go vet
,golint
, β¦) β probably following PRs to come π.binary
: buildtraefik
usinggox
and but the result indist
(just like now, but using volumes).test
(test-unit
,test-integration
) : run tests (there is none for now but will be π).image
: make the final image that will be deployed on the docker hub (with just the binary in it).This looks like :
The way the
build.Dockerfile
is done for now is almost completely arbitrary (grouping thego get
like that), but it's related to the following question (that could be handled in this PR too) :What about using some tools to vendor dependencies ? (like godep or the experimental vendor thingy in go 1.5) β this would ease a bit the dev on
traefik
, with or without the use of theMakefile
anddocker
π.πΈ