Use Host IP address if PrimaryIP is empty #1978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in Traefik ! 👍 You cannot manually edit files in the We don't want quick-fix and in respect of this rule I must close your PR.
— Solomon Hykes https://twitter.com/solomonstre/status/715277134978113536 We will be very happy if you open a "non quick-fix" PR on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description
When host network is selected on rancher container, traefik returns as primary IP address "". This results in proxying to http://:PORT. With this PR if the IP address is empty, the returned IP address is host's address where the container is running.
Follow up description: #1498
This is a quick-fix and should be made differently in future. Probably it should start by detecting what network was chosen on a container and based on that return the proper IP address.