Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sameSite field for wrr load balancer sticky cookie #10066

Merged
merged 1 commit into from Aug 8, 2023

Conversation

sunyakun
Copy link
Contributor

@sunyakun sunyakun commented Aug 7, 2023

What does this PR do?

Fixes #10009

Motivation

The load-balancer implementation was changed to traefik/wrr in PR: #9431 but the wrr disregards the sameSite field (SourceCode).

More

  • Set 'sameSite' field for the sticky cookie
  • Add unit test for sticky cookie

@ldez ldez marked this pull request as draft August 7, 2023 09:33
@ldez ldez marked this pull request as ready for review August 7, 2023 09:38
@ldez ldez changed the base branch from master to v3.0 August 7, 2023 09:39
@ldez ldez added this to the 3.0 milestone Aug 7, 2023
@ldez ldez changed the title Fix: set sameSite field for wrr load balancer sticky cookie Set sameSite field for wrr load balancer sticky cookie Aug 7, 2023
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit d6457e6 into traefik:v3.0 Aug 8, 2023
12 checks passed
@traefiker traefiker mentioned this pull request Aug 8, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants