Rework servers load-balancer to use the WRR #9431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
added
kind/enhancement
kevinpollet
force-pushed
the
refacto-lb
branch
5 times, most recently
from
51882f9
to
3b34ec4
Compare
|
Linking the motivation of the motivation :) |
juliens
force-pushed
the
refacto-lb
branch
2 times, most recently
from
54c26d4
to
37d7ad9
Compare
kevinpollet
force-pushed
the
refacto-lb
branch
from
a57d3fd
to
e232ede
Compare
kevinpollet
force-pushed
the
refacto-lb
branch
from
451f09c
to
2ba66e0
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reworks the servers load-balancer to use the WRR load balancer instead of the oxy load balancer.
The healthcheck was rewritten to fit the WRR healthcheck mechanism.
Motivation
To simplify the code base.
More
- [ ] Added/updated documentationAdditional Notes
As we are reusing the sticky cookie mechanism we implemented in WRR, we dropped the support of the old cookie value (before 2.5) in the sticky feature.
This means that if a Traefik is upgraded from <2.5 to this version, the active user's sticky session will be discarded.
The services are now reused, this means that if two routers use the same service, load balancing will be shared by both routers.
CloseNotifier implementations are removed because they are not used anymore as the http.Request context always has a cancellable context. See https://github.com/golang/go/blob/7c84234142149bd24a4096c6cab691d3593f3431/src/net/http/httputil/reverseproxy.go#L340
The pipelining middleware is also removed because of https://github.com/golang/go/blob/32a52e039953889a3aaa6a3e7f0ad0f7dfcbeac3/src/net/http/server.go#L670
Co-authored-by: Kevin Pollet pollet.kevin@gmail.com